[RFA] Fix two memory leaks

Tom Tromey tromey@redhat.com
Wed Oct 24 14:55:00 GMT 2012

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> This one looks good to me. But I'm wonderin if we shouldn't also
Joel> document the fact that decode_line_with_current_source returns
Joel> a structure that contains newly allocated memory?

The docs for it should probably reference decode_line_full.

>> * linespec.c (parse_linespec): Do cleanups after
>> parsing a convenience variable.

Joel> This one looks good to me too.

Joel> You might want to wait for a day or two before checking in, as these
Joel> files are not within my area of expertise. But I verified that the
Joel> memory is allocated on the heap, and leaked if not free'ed.

I think they are both ok as well.


More information about the Gdb-patches mailing list