[testsuite commit] Fix -m32 results [Re: [PATCH] Remove some KPASSes in gdb.base/callfuncs.exp]

Jan Kratochvil jan.kratochvil@redhat.com
Wed Oct 24 13:48:00 GMT 2012


On Tue, 23 Oct 2012 20:27:40 +0200, Mark Kettenis wrote:
> Just fixed the bugs.  Committed as obvious.

It is a testsuite results regression in -m32 mode:

--- 20121023Build-gdbcvs-f18/fedora-18-x86_64/out/gdb-m32.sum   2012-10-23 03:34:35.546531678 +0200
+++ 20121024Build-gdbcvs-f18/fedora-18-x86_64/out/gdb-m32.sum   2012-10-24 03:52:42.269267826 +0200
-KPASS: gdb.base/callfuncs.exp: call inferior func with struct - returns float _Complex (PRMS gdb/12796)
-KFAIL: gdb.base/callfuncs.exp: call inferior func with struct - returns double _Complex (PRMS: gdb/12796)
-KFAIL: gdb.base/callfuncs.exp: call inferior func with struct - returns long double _Complex (PRMS: gdb/12796)
+PASS: gdb.base/callfuncs.exp: call inferior func with struct - returns float _Complex
+FAIL: gdb.base/callfuncs.exp: call inferior func with struct - returns double _Complex
+FAIL: gdb.base/callfuncs.exp: call inferior func with struct - returns long double _Complex

This is because setup_kfail_for_target is broken by design.

Checked in its workaround.

There are more incorrect uses of setup_kfail_for_target but they already KPASS
so asked in BZ for them:
	http://sourceware.org/bugzilla/show_bug.cgi?id=13808#c1
	http://sourceware.org/bugzilla/show_bug.cgi?id=12790#c1


Regards,
Jan


http://sourceware.org/ml/gdb-cvs/2012-10/msg00100.html

--- src/gdb/testsuite/ChangeLog	2012/10/23 18:25:24	1.3423
+++ src/gdb/testsuite/ChangeLog	2012/10/24 13:45:50	1.3424
@@ -1,3 +1,8 @@
+2012-10-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.base/callfuncs.exp (do_function_calls): Fix
+	setup_kfail_for_target for -m32 mode.
+
 2012-10-23  Mark Kettenis  <kettenis@gnu.org>
 
 	* gdb.base/callfuncs.exp: PR gdb/12796, gdb/12798 and gdb/12800
--- src/gdb/testsuite/gdb.base/callfuncs.exp	2012/10/23 18:25:25	1.54
+++ src/gdb/testsuite/gdb.base/callfuncs.exp	2012/10/24 13:45:51	1.55
@@ -245,11 +245,15 @@
 	gdb_test "p t_structs_fc(struct_val1)" ".*= 3 \\+ 3 \\* I" \
 	    "call inferior func with struct - returns float _Complex"
 
-	setup_kfail_for_target gdb/12783 "i?86-*-*"
+	if [is_x86_like_target] {
+	    setup_kfail gdb/12783 "*-*-*"
+	}
 	gdb_test "p t_structs_dc(struct_val1)" ".*= 4 \\+ 4 \\* I" \
 	    "call inferior func with struct - returns double _Complex"
 
-	setup_kfail_for_target gdb/12783 "i?86-*-*"
+	if [is_x86_like_target] {
+	    setup_kfail gdb/12783 "*-*-*"
+	}
 	gdb_test "p t_structs_ldc(struct_val1)" "= 5 \\+ 5 \\* I" \
 	    "call inferior func with struct - returns long double _Complex"
     }



More information about the Gdb-patches mailing list