[7.5] PATCH: PR backtrace/14646 [x32] backtrace doesn't work
H.J. Lu
hjl.tools@gmail.com
Sun Oct 21 02:06:00 GMT 2012
On Sat, Oct 20, 2012 at 6:56 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> This patch backports the fix from trunk to 7.5 branch. Tested on
>> Linux/x86-64 and Linux/x32. OK to install?
> [...]
>> PR backtrace/14646
>> PR gdb/14647
>> * i386-tdep.h (gdbarch_tdep): Remove sp_regnum_from_eax and
>> pc_regnum_from_eax.
>> * i386-tdep.c (i386_gdbarch_init): Don't use sp_regnum_from_eax
>> nor pc_regnum_from_eax.
>> * amd64-tdep.c (amd64_x32_init_abi): Don't set sp_regnum_from_eax
>> nor pc_regnum_from_eax.
>
> I'm sorry to say that I am not comfortable at all with this going
> in the 7.5 branch. If Mark is super confident, then OK, but this is
> touching sp/pc handling for all x86 and x86-64 targets. And I don't
> think that the issue this patch is fixing is that critical.
>
This patch reverts the changed made on 7.5 branch, which
brings 7.5 branch back to 7.4 branch. It should be 100% safe.
--
H.J.
More information about the Gdb-patches
mailing list