[PATCH] enhancement of mi_cmd_data_write_memory_bytes for filling memory regions (was [PATCH] new MI command for pattern filling of memory regions)

[Giuseppe MONTALTO]

Thanks again,

Please, find attached a new patch with all the requested changes (also includes
The additons to NEWS and gdb.texinfo that I previously posted in a separate patch).

Regards,
	Giuseppe

> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Thursday, October 18, 2012 5:41 PM
> To: Giuseppe MONTALTO
> Cc: Tom Tromey; gdb-patches@sourceware.org; Abid, Hafiz
> Subject: Re: [PATCH] enhancement of mi_cmd_data_write_memory_bytes
> for filling memory regions (was [PATCH] new MI command for pattern filling
> of memory regions)
> 
> On 09/27/2012 04:26 PM, Giuseppe MONTALTO wrote:
> > +++ b/gdb/testsuite/gdb.mi/mi-fill-memory.exp
> > @@ -0,0 +1,68 @@
> > +# Copyright (C) 2012 Free Software Foundation, Inc.
> > +# Copyright (C) 2012 STMicroelectronics
> 
> Sorry, this is not OK.  In order to accept it, the copyright needs to be assigned
> to the FSF, only.
> 
> 
> While at it:
> 
> > +
> > +	* mi/mi-main.c  (mi_cmd_data_write_memory): Additional
> 
>                       ^^  single space here.
> 
> 
> > +	parameter for pattern filling of memory regions
>                                                        ^ Missing period.
> 
> I'd mention COUNT explicitly, to help grepping.  Thus:
> 
> 	* mi/mi-main.c (mi_cmd_data_write_memory): Handle additional
> 	parameter COUNT, for pattern filling of memory regions.
> 
> 
> > +if {[build_executable ${testfile}.exp ${binfile} ${srcfile}.c {debug
> > +additional_flags=-DFAKEARGV}] == -1} {
> 
> This FAKEARGV usage looks like an unnecessary copy&paste.  Please remove
> it.
> It was removed from mi-read-memory.exp too on 2012-07-10.
> 
> > +# test basic Machine interface (MI) operations # # Verify that, using
> > +the MI, we can load a program and do # other basic things that are
> > +used by all test files through  mi_gdb_exit, # mi_gdb_start,
> > +mi_delete_breakpoints, mi_gdb_reinitialize_dir and # mi_gdb_load, so
> > +we can safely use those.
> > +#
> > +# The goal is not to test gdb functionality, which is done by other
> > +tests, # but the command syntax and correct output response to MI
> operations.
> > +#
> 
> All this text too.  I see that it's been blindly copied to a _lot_ of files.. :-/
> 
> --
> Pedro Alves

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-V.8.patch
Type: application/octet-stream
Size: 7065 bytes
Desc: patch-V.8.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20121018/0d7480fd/attachment.obj>