RFA: probable rs6000-aix-tdep.c bug found by clang

Joel Brobecker brobecker@adacore.com
Thu Oct 18 15:33:00 GMT 2012

> >> 	* rs6000-aix-tdep.c (rs6000_aix_osabi_sniffer): Remove extraneous
> >> 	semicolon.
> I suspect this is the root cause of PR8966 (AIX 5.1 single_step configuration
> is broken).  http://sourceware.org/bugzilla/show_bug.cgi?id=8966
> We're always returning the _UNKNOWN osabi, so this is unreachable:

On the contrary, I think we always returned the AIX osabi.

> > So, isn't rs6000_aix_osabi_sniffer going to be called if, and only
> > if, the bfd has a bfd_target_xcoff_flavour, thus making the check
> > superfluous?
> Sure looks like it.

OK - I will take care of removing the condition and simplifying
the function.


More information about the Gdb-patches mailing list