Regression for gdb.base/stap-probe.exp (and some others) [Re: [patch] Have gdb_breakpoint call pass]

Jan Kratochvil jan.kratochvil@redhat.com
Mon Oct 15 18:35:00 GMT 2012


Hi Doug,

On Mon, 15 Oct 2012 19:41:28 +0200, dje@google.com wrote:
> This patch fixes stap-probe.exp on the Fedora box I tested on.

Yes, it does.

> I didn't test jmisc.exp but it is likely the same issue.

No, it is not.

I guess you agree, I will check it in.  With '{ allow-pending }' the function
gets passed "{ allow-pending }" while with '{allow-pending}' it gets passed
"allow-pending".  tcl-8.5.12-3.fc18.x86_64


Thanks,
Jan


gdb/testsuite/
2012-10-15  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Fix recent gdb_breakpoint regression.
	* gdb.java/jmisc.exp: gdb_breakpoint for $function - remove spaces from
	curly bracketed parameter.
	* gdb.java/jprint.exp: Likewise.

diff --git a/gdb/testsuite/gdb.java/jmisc.exp b/gdb/testsuite/gdb.java/jmisc.exp
index 7215861..64ae559 100644
--- a/gdb/testsuite/gdb.java/jmisc.exp
+++ b/gdb/testsuite/gdb.java/jmisc.exp
@@ -43,8 +43,8 @@ if [set_lang_java] then {
     # signature.
     runto_main
     set function "${testfile}.main(java.lang.String\[\])"
-    gdb_breakpoint "$function" { allow-pending }
-    gdb_breakpoint "${function}void" { allow-pending }
+    gdb_breakpoint "$function" {allow-pending}
+    gdb_breakpoint "${function}void" {allow-pending}
     gdb_continue_to_breakpoint $function
 
     gdb_test_multiple "ptype jmisc" "ptype jmisc" {
diff --git a/gdb/testsuite/gdb.java/jprint.exp b/gdb/testsuite/gdb.java/jprint.exp
index b2d5d31..ac5c55c 100644
--- a/gdb/testsuite/gdb.java/jprint.exp
+++ b/gdb/testsuite/gdb.java/jprint.exp
@@ -43,8 +43,8 @@ if [set_lang_java] then {
     # signature.
     runto_main
     set function "${testfile}.main(java.lang.String\[\])"
-    gdb_breakpoint "$function" { allow-pending }
-    gdb_breakpoint "${function}void" { allow-pending }
+    gdb_breakpoint "$function" {allow-pending}
+    gdb_breakpoint "${function}void" {allow-pending}
     gdb_continue_to_breakpoint $function
 
     gdb_test "p jvclass.addprint(4,5,6)" " = 15" "unambiguous static call"



More information about the Gdb-patches mailing list