Regression for gdb.base/stap-probe.exp (and some others) [Re: [patch] Have gdb_breakpoint call pass]

[Jan Kratochvil]

On Mon, 01 Oct 2012 18:49:21 +0200, dje@google.com wrote:
> 2012-10-01  Doug Evans  <dje@google.com>
> 
> 	* lib/gdb.exp (gdb_breakpoint): Fix varargs scan.
> 	Recognize "message" -> print pass and fail.  Add eof case.
> 	(runto): Recognize message, no-message.  Print pass/fail if requested,
> 	with same treatment as gdb_breakpoint.
> 	(runto_main): Pass no-message to runto.
> 	(gdb_internal_error_resync): Add log message.
> 	(gdb_file_cmd): Tweak internal error fail text for consistency.

 Running gdb/testsuite/gdb.base/stap-probe.exp ...
 PASS: gdb.base/stap-probe.exp: without semaphore, not optimized: check argument not at probe point
 PASS: gdb.base/stap-probe.exp: without semaphore, not optimized: info probes stap
-PASS: gdb.base/stap-probe.exp: without semaphore, not optimized: run to -pstap test:user
+FAIL: gdb.base/stap-probe.exp: without semaphore, not optimized: run to -pstap test:user
[...]
(many of PASS->FAIL for gdb.base/stap-probe.exp)

8ff7e49469b5392bd0663a503023b9987dd1b9de is the first bad commit
commit 8ff7e49469b5392bd0663a503023b9987dd1b9de
Author: Doug Evans <dje@google.com>
Date:   Thu Oct 11 15:59:56 2012 +0000

	* lib/gdb.exp (gdb_breakpoint): Fix varargs scan.
	Recognize "message" -> print pass and fail.  Add eof case.
	(runto): Recognize message, no-message.  Print pass/fail if requested,
	with same treatment as gdb_breakpoint.
	(runto_main): Pass no-message to runto.
	(gdb_internal_error_resync): Add log message.
	(gdb_file_cmd): Tweak internal error fail text for consistency.


-(gdb) break -pstap test:user
-Breakpoint 2 at 0x4005a1
-(gdb) run 
-[...]
-(gdb) PASS: gdb.base/stap-probe.exp: without semaphore, not optimized: run to -pstap test:user
+(gdb) break -pstap
+Function "-pstap" not defined.
+Make breakpoint pending on future shared library load? (y or [n]) n
+(gdb) FAIL: gdb.base/stap-probe.exp: without semaphore, not optimized: run to -pstap test:user


Also:
 (gdb) break jmisc.main(java.lang.String[])
 Function "jmisc.main(java.lang.String[])" not defined.
-Make breakpoint pending on future shared library load? (y or [n]) y
-Breakpoint 2 (jmisc.main(java.lang.String[])) pending.
[...]
+Make breakpoint pending on future shared library load? (y or [n]) n
+(gdb) FAIL: gdb.java/jmisc.exp: setting breakpoint at jmisc.main(java.lang.String[])



Regards,
Jan