[PATCH] use gdbarch_addr_bits_remove for entry point address

Pedro Alves palves@redhat.com
Mon Nov 26 11:57:00 GMT 2012


This version is OK, but please fix up the ChangeLog entry.

> 2012-11-24  Daniel Jacobowitz  <dan@codesourcery.com>
> 	    Kazu Hirata  <kazu@codesourcery.com>
> 	    Yao Qi  <yao@codesourcery.com>
> 
> 	* objfiles.c (entry_point_address_query): Move some code ...
> 	(init_entry_point_info): ... here.

Please be more specific:

 	* objfiles.c (entry_point_address_query): Call
	gdbarch_convert_from_func_ptr_addr and gdbarch_addr_bits_remove
	here ...
 	(init_entry_point_info): ... instead of here.

That's more useful for archaeology.

> 	* solib-svr4.c (exec_entry_point): Likewise.

"Likewise" here doesn't make sense.  Perhaps:

 	* solib-svr4.c (exec_entry_point): Call gdbarch_addr_bits_remove.

> 	* symfile.c (generic_load): Call gdbarch_addr_bits_remove on
> 	the entry address.

-- 
Pedro Alves



More information about the Gdb-patches mailing list