PING: [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : mardi 6 novembre 2012 20:02
> À : Pierre Muller
> Cc : devans@sourceware.org; gdb-patches@sourceware.org
> Objet : Re: [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012
> 
> On 11/06/2012 11:08 AM, Pierre Muller wrote:
> 
> >> 281a282,283
> >>> gdb/dwarf2read.c:8612: regression: xasprintf: Do not use xasprintf(),
> >> instead use xstrprintf
> >> gdb/dwarf2read.c:8612:  xasprintf (&virtual_dwo_name, ',
> >>> gdb/dwarf2read.c:8984: regression: xasprintf: Do not use xasprintf(),
> >> instead use xstrprintf
> >> gdb/dwarf2read.c:8984:  xasprintf (&dwp_name, ', dwarf2_per_objfile-
> >>> objfile->name);
> >
> > Doug,
> >
> > could you check the patch below
> > which removes the new ARI warnings about use of
> > xasprintf function in the commit
> >
> > http://sourceware.org/ml/gdb-cvs/2012-11/msg00027.html

  Doug didn't reply yet to this RFA...
 
> Déjà vu :-)
> 
> http://sourceware.org/ml/gdb-patches/2009-03/msg00576.html
> 
> This removes the last use of xasprintf in the tree; we should delete
> it to avoid new uses creeping in.

  There is probably a list of other similar functions
that we should obsolete.
  The main question is, should we do it brutally
or softly.

  1-- Brutal method:
Remove function from both header and C sources
as well as from ARI script.


  2 -- Soft method:
Start by simply removing function from header.
Change function to static.
Wait for one release and suppress completely.

  Method 1 is simpler, but
not adapted to some functions that are used internally.
  Method 2 is gentler to outsiders using gdb sources for
external projects, like the inclusion of libgdb.a into
the Free Pascal IDE, which I basically try to maintain...
Yes, I know I should be using mi, but I never got to 
switch :(

Pierre Muller 
as ARI maintainer