[PATCH] Always include defs.h first.

Pedro Alves palves@redhat.com
Thu Nov 8 17:16:00 GMT 2012


On 11/08/2012 05:04 PM, Pierre Muller wrote:
>   Hi Pedro,
> 
>   I think you missed the python subdirectory...
> $ grep \"defs\.h\" */*.h
> python/py-event.h:#include "defs.h"
> python/py-events.h:#include "defs.h"

Indeed I have.

> The C sources also do not all include defs.h ...

Yeah.  They're getting it from those headers.  IMO, this makes it
easy to forget about it, and risk some change adding the inclusion
of a system header before including py-events.h, etc.  But since
we don't have consensus, I'll leave it at that.

-- 
Pedro Alves



More information about the Gdb-patches mailing list