[patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries.

[Pedro Alves]

On 05/24/2012 12:28 AM, John Steele Scott wrote:

> -  /* These cache the results of producer_is_gxx_lt_4_6.
> -     CHECKED_PRODUCER is set if PRODUCER_IS_GXX_LT_4_6 is valid.  This
> -     information is cached because profiling CU expansion showed
> -     excessive time spent in producer_is_gxx_lt_4_6.  */
> +  /* These cache the results for producer_is_gxx_lt_4_6 and producer_is_icc.
> +     CHECKED_PRODUCER is set if both PRODUCER_IS_GXX_LT_4_6 and PRODUCER_IS_ICC
> +     are valid.  This information is cached because profiling CU expansion
> +     showed excessive time spent in producer_is_gxx_lt_4_6.  */
>    unsigned int checked_producer : 1;
>    unsigned int producer_is_gxx_lt_4_6 : 1;
> +  unsigned int producer_is_icc : 1;


Doesn't matter much at this point, since you'd need two bits anyway,
but I'll note that producer_is_gxx_lt_4_6 and producer_is_icc are mutually
exclusive, so an enum (ENUM_BITFIELD) would be a better match.

-- 
Pedro Alves