[RFA] Suppress stap-trace.exp when compilation fails

Keith Seitz keiths@redhat.com
Wed May 23 17:15:00 GMT 2012


Hi,

stap-trace.exp does not check the return value of its compile-a-testcase 
wrapper procedure, so when compilation of the test case fails, it 
attempts to run the tests anyway instead of nicely bailing out.

This patch addresses this by fixing the compile wrapper to always return 
a valid value and checking this procedure's return value before running 
the tests.

Okay?
Keith

testsuite/ChangeLog

2012-05-23  Keith Seitz  <keiths@redhat.com>

	* gdb.trace/stap-trace.exp: If compile_stap_bin fails,
	return -1 to suppress the rest of the tests.
	(compile_stap_bin): Return boolean success value.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: suppress-stap-trace.patch
Type: text/x-patch
Size: 835 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20120523/4ee0359e/attachment.bin>


More information about the Gdb-patches mailing list