New ARI warning Mon May 14 01:55:48 UTC 2012

Tom Tromey tromey@redhat.com
Tue May 15 20:26:00 GMT 2012


>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> GDB_PY_LLU_ARG should be used with gdb_py_ulongest.  What this type
Tom> refers to depends on configure.  It is done this way to let us handle
Tom> multiple Python versions in the same sources.  Your patch probably
Tom> breaks on some version or another.  See python-internal.h.

It was simplest to just fix it.
Patch appended.

Tom

2012-05-15  Tom Tromey  <tromey@redhat.com>

	* python/python.c (gdbpy_find_pc_line): Use gdb_py_ulongest.

Index: python/python.c
===================================================================
RCS file: /cvs/src/src/gdb/python/python.c,v
retrieving revision 1.88
diff -u -r1.88 python.c
--- python/python.c	14 May 2012 03:06:47 -0000	1.88
+++ python/python.c	15 May 2012 20:25:15 -0000
@@ -639,7 +639,7 @@
 {
   struct symtab_and_line sal;
   CORE_ADDR pc;
-  ULONGEST pc_llu;
+  gdb_py_ulongest pc_llu;
 
   if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc_llu))
     return NULL;



More information about the Gdb-patches mailing list