[SH] gdb.arch/gdb1291.exp, gdb.arch/gdb1431.exp

[Thomas Schwinge]

Hi!

On Tue, 27 Mar 2012 21:52:13 -0700, Kevin Buettner <kevinb@redhat.com> wrote:
> On Fri, 23 Mar 2012 16:46:32 +0100
> Thomas Schwinge <thomas@codesourcery.com> wrote:
> 
> > Exactly the same for gdb.arch/gdb1431.exp: their source files
> > (gdb.arch/gdb1291.s, gdb.arch/gdb1431.s) are identical, and I first
> > propose to get rid of one of them:
> > 
> > gdb/testsuite/
> > 
> > 	* gdb.arch/gdb1431.s: Remove file.
> > 	* gdb.arch/gdb1431.exp (srcfile): Refer to gdb1291.s.
> 
> I don't know enough about the tests in question to say whether
> this is a good approach or not.

Apparently nobody else does, too.  ;-)

> Is there a chance that someone
> will want to tweak the code for one of the test cases without
> also having to tweak the other?

No, given what they're testing, I don't expect this would ever happen.


Grüße,
 Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20120330/4a5d7319/attachment.sig>