[RFA/Ada] Crash when trying to set value of packed array element

[Jan Kratochvil]

On Fri, 16 Mar 2012 18:59:33 +0100, Joel Brobecker wrote:
> > > -      CORE_ADDR new_addr;
> > > +      long new_offset = offset;
> > 
> > Nitpick - LONGEST (Siddhesh Poyarekar is working on a more thorough fix).
> 
> I know you said it's a nitpick, but I don't understand why you think
> it should be LONGEST. "offset" itself is a long, and the only use
> of that new_offset is for set_value_offset, which takes an int. Are
> the changes you are referring to going to make that a LONGEST?

Yes; not sure if in the first phase but I hope so.


> I'll fix that as a followup patch if you confirm the above.

I do not think it matters if it is checked in as is, there is a huge amount of
such cases needing to be caught anyway.


Thanks,
Jan