[PATCH 1/3] Refactor internal variable mechanism

Tom Tromey tromey@redhat.com
Fri Mar 9 21:03:00 GMT 2012


>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> This is the first patch, which refactors the internal variable
Sergio> mechanism.  It creates new methods, for example to compile an internal
Sergio> variable into agent expression.

Sergio> Is this OK to check-in?

I intend to approve this one but I would like to wait for other comments
first.

Really I'm replying now to point out a nit :)

Sergio> +/* Implementation of `thread' variable.  */
Sergio> +
Sergio> +static struct internalvar_funcs thread_funcs =

This one should be 'const' like the others are.

Tom



More information about the Gdb-patches mailing list