[RFA] gdb_get_line_number on unknown tags

[Keith Seitz]

On 03/08/2012 02:24 PM, Joel Brobecker wrote:
>>>>>>> "Keith" == Keith Seitz<keiths@redhat.com>  writes:
>>
>> Keith>  This is occurring because the two tests which do it are using
>> Keith>  gdb_get_line_number on a tag which is not defined in the source
>> Keith>  file.
>>
>> I wonder whether this should be an error.
>
> Seems like a good idea...

Well, we three agree, so here it is. It exposed buglets in three other 
tests (which appear to be copies of one common file).

Ok?

Keith

testsuite/ChangeLog
2012-03-08  Keith Seitz  <keiths@redhat.com>

	* lib/gdb.exp (gdb_get_line_number): Throw an
	error instead of returning -1.
	* gdb.base/break.exp: Remove unused variable
	bp_location5.
	* gdb.base/hbreak2.exp: Likewise.
	* gdb.base/sepdebug.exp: Likewise.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gdb_get_line_number-error.patch
Type: text/x-patch
Size: 3376 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20120308/c62d077d/attachment.bin>