Fix PR 14392

Tom Tromey tromey@redhat.com
Tue Jul 31 14:14:00 GMT 2012


This fixes PR 14392.

I believe the bug is just a pasto.
We call filter_sals on 'sals' but should call it on 'sals_end'.

I'll check it in next week unless there are objections.
I would like to put it in 7.5 as well.

I could not reproduce the crash in the PR, so no test case.

Tom

2012-07-31  Tom Tromey  <tromey@redhat.com>

	PR cli/14392:
	* cli/cli-cmds.c (list_command): Filter 'sals_end'.

Index: cli/cli-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
retrieving revision 1.132
diff -u -r1.132 cli-cmds.c
--- cli/cli-cmds.c	26 Jul 2012 16:57:22 -0000	1.132
+++ cli/cli-cmds.c	31 Jul 2012 14:12:46 -0000
@@ -959,7 +959,7 @@
 	  else
 	    sals_end = decode_line_1 (&arg1, DECODE_LINE_LIST_MODE,
 				      sal.symtab, sal.line);
-	  filter_sals (&sals);
+	  filter_sals (&sals_end);
 	  if (sals_end.nelts == 0)
 	    return;
 	  if (sals_end.nelts > 1)



More information about the Gdb-patches mailing list