[patch] Remove one immediate_quit++-- (in auto-load.c)
Jan Kratochvil
jan.kratochvil@redhat.com
Thu Jul 26 13:55:00 GMT 2012
Hi Doug,
Tom has notified me on #gdb there was one needless and probably even incorrect
immediate_quit++ (and --).
despite it is in auto-load.c it was only moved there with other code, it
originates from patch:
commit 47d11be572aaf42cc67e6d925271d44bdecd104d
Author: Doug Evans <dje@google.com>
Date: Fri Apr 23 16:20:08 2010 +0000
Add support for auto-loading scripts from .debug_gdb_scripts section.
Originally there was printf_filtered which does not need it. Later it is just
around code with no UI output:
commit 2e0e11bc91732db59fe04fca4f2dceff2bb4a2ad
Author: Doug Evans <dje@google.com>
Date: Fri May 13 22:11:45 2011 +0000
I will check it in.
Thanks,
Jan
gdb/
2012-07-26 Jan Kratochvil <jan.kratochvil@redhat.com>
* auto-load.c (auto_load_info_scripts): Remove immediate_quit increment
and decrement.
diff --git a/gdb/auto-load.c b/gdb/auto-load.c
index 87dd1e4..2cc52c6 100644
--- a/gdb/auto-load.c
+++ b/gdb/auto-load.c
@@ -916,11 +916,9 @@ auto_load_info_scripts (char *pattern, int from_tty,
{
struct collect_matching_scripts_data data = { &scripts, language };
- immediate_quit++;
/* Pass a pointer to scripts as VEC_safe_push can realloc space. */
htab_traverse_noresize (pspace_info->loaded_scripts,
collect_matching_scripts, &data);
- immediate_quit--;
}
nr_scripts = VEC_length (loaded_script_ptr, scripts);
More information about the Gdb-patches
mailing list