Re-evaluate floating varobj as part of varobj_invalidate.

Tom Tromey tromey@redhat.com
Wed Jul 25 17:52:00 GMT 2012


>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:

Andrew> I have a bug & patch, but no great way to reproduce the issue as
Andrew> it's a use of pointer after free issue,

I suspect the recent-ish change to use -lmcheck by default will cause us
to catch this bug in the test suite, at least on glibc-using systems.

Andrew> The patch below simply removes the special case for floating
Andrew> varobj objects from varobj_invalidate_iter, and causes them to
Andrew> be re-evaluated or marked as invalid.

Seems reasonable to me.

Andrew> 2012-07-25  Andrew Burgess  <aburgess@broadcom.com>
Andrew> 	* varobj.c (varobj_invalidate_iter): All varobj must be marked as
Andrew> 	invalid or reevaluated to prevent prevent references to possibly
Andrew> 	delete'd type objects being left in the varobj.

Patch is ok.

Tom



More information about the Gdb-patches mailing list