[patch] MI telnet service

Gary Benson gbenson@redhat.com
Thu Jul 12 15:08:00 GMT 2012


Abid, Hafiz wrote:
> Gary Benson wrote:
> > > diff -N gdb/testsuite/gdb.mi/mi-telnet.c
> > > --- /dev/null	1 Jan 1970 00:00:00 -0000
> > > +++ gdb/testsuite/gdb.mi/mi-telnet.c	12 Jul 2012 10:35:17 -0000
> > 
> > The indentation in this file is completely wrong.  There's also
> > a lot of missing space before '(' for function calls and missing
> > space after casts.
> 
> I thought we are not required to follow the convention in the test
> program source.

Ah, possibly.  Perhaps someone more familiar could comment?

> Thanks for reviewing.

No problem :)

Cheers,
Gary

-- 
http://gbenson.net/



More information about the Gdb-patches mailing list