[04/10] watchpoint.exp: Always run the complex watchpoints tests.

Pedro Alves palves@redhat.com
Thu Jan 26 14:19:00 GMT 2012


"Only enabled for some targets merely because it has not been
tested elsewhere." is clearly the wrong policy.  You end up with tests never
enabled.  A better policy is to start with the tests enabled, and disable them
on targets that we find can run the test.

The complex tests pass cleanly on x86_64 Fedora 16, native and gdbserver.

2012-01-26  Pedro Alves  <palves@redhat.com>

	* gdb.base/watchpoint.exp: Always run test_complex_watchpoint.
---

 gdb/testsuite/gdb.base/watchpoint.exp |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/gdb/testsuite/gdb.base/watchpoint.exp b/gdb/testsuite/gdb.base/watchpoint.exp
index 9aeb5ec..3879308 100644
--- a/gdb/testsuite/gdb.base/watchpoint.exp
+++ b/gdb/testsuite/gdb.base/watchpoint.exp
@@ -803,13 +803,7 @@ if [initialize] then {
 	gdb_load $binfile
     }

-    # Only enabled for some targets merely because it has not been tested
-    # elsewhere.
-    if {[istarget "hppa*-*-*"] || \
-	    [istarget "sparc*-*-sunos*"] || \
-	    [istarget "m32r-*-*"]} then {
-	test_complex_watchpoint
-    }
+    test_complex_watchpoint

     test_inaccessible_watchpoint



More information about the Gdb-patches mailing list