[patch] Turn on dbg msg of IPA along with gdbserver's

[Yao Qi]

On 01/04/2012 08:02 PM, Pedro Alves wrote:
> Since it's in the inferior, I just do "print debug_threads = 1"
> from gdb.   It won't work if the ipa is stripped though, so I won't
> object to something like this.
> 

Well, I don't mind to turn debug flag on in this way.  However,
`debug_threads' is confusing here.  How about change this flag to
`debug_agent'?

>> Since gdbserver has been a good
>> mechanism to access gdb_agent_XXX variables in inferior's space, we can
>> do similar thing to turn on IPA's debug flag.
>>
>> This patch renames debug flag `debug_threads' to `gdb_agent_debug', and
>> let gdbserver to set it if `debug_threads' (in gdbserver's space) is
>> true.  For the user's perspective, if gdbserver option --debug is on,
>> IPA's debugging message comes into the gdbserver's debug message.
>>
>> OK for mainline?
> 
> Sorry, not in this form.  It's quite useful to be able to turn
> gdbserver's and the IPA's debug output independently.  I'd like to
> retain that possibility.

That is fine to me.  It is reasonable to decouple gdbserver's and IPA's
debug output.

-- 
Yao (齐尧)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-set-debug-flag-for-ipa.patch
Type: text/x-patch
Size: 1014 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20120104/5eb8ea65/attachment.bin>