[patch] Assert when 'break' with no arguments

[Aleksandar Ristovski]

On 12-02-14 03:12 PM, Alfred M. Szmidt wrote:
>     2012-02-14  Aleksandar Ristovski<aristovski@qnx.com>
>
> 	* frame.c (find_frame_sal): Initialise sal->pspace field from frame
> 	data.
>
> I'm guessing that American spelling is prefered, since that is what is
> used in GDB.

Changed.

>
> 	* stack.c (set_last_displayed_sal): Perform sanity check of the data
> 	passed in, in particular, validate that PSPACE is not NULL if requesting
> 	valid last_displayed_* data.
>
> Please don't use regexps in the ChangeLog.  Also, descriptions on why
> the change is done is better placed in the source file.  So here, you
> could just write:
>
>    Validate that PSPACE is not NULL.

Ok.

>
> Or something,
>
>     Testsuite:
>     2012-02-14  Aleksandar Ristovski<aristovski@qnx.com>
>
> 	* gdb.base/break-inline.exp: New test.
> 	* gdb.base/break-inline.c: New test.
>
> This should say `New file.' since that is what you have added.

Ok.

>
> Space after opening paren (though not for _()).

Ok.

>        Copyright (C) 2012 Free Software
>        Foundation, Inc.
>
> This isn't formated correctly.

Ok.


Other changes performed as well.


2012-02-14  Aleksandar Ristovski  <aristovski@qnx.com>

     * frame.c (find_frame_sal): Initialize sal->pspace field from frame
     data.
     * stack.c (set_last_displayed_sal): Validate that PSPACE is not NULL.



2012-02-14  Aleksandar Ristovski  <aristovski@qnx.com>

     * gdb.base/break-inline.exp: New file.
     * gdb.base/break-inline.c: New file.



Patch + tests attached.


Thanks,

Aleksandar



-------------- next part --------------
A non-text attachment was scrubbed...
Name: pspace-assert-201202141536.patch
Type: text/x-patch
Size: 1087 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20120214/39e0a9b3/attachment.bin>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: break-inline.exp
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20120214/39e0a9b3/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: break-inline.c
Type: text/x-csrc
Size: 874 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20120214/39e0a9b3/attachment-0001.bin>