[RFA/OBVIOUS?] ui_file_new function missing "extern" in header.

Tom Tromey tromey@redhat.com
Tue Dec 18 16:27:00 GMT 2012


>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>    This is both a RFA
Pierre>  and a question about:
Pierre>   should this be considered as an obvious fix?
  
Pierre>   i.e. shouldn't all functions declared in headers
Pierre> have the extern modifier?
Pierre>   Is this mandatory?

It isn't mandatory right now, gdb does it both ways.  I don't really
care about this issue so I just tend to use whatever is used nearby.  I
think Joel at least has argued for making this part of the gdb style.

Tom



More information about the Gdb-patches mailing list