[RFA/OBVIOUS?] ui_file_new function missing "extern" in header.

[Pierre Muller]

   This is both a RFA
 and a question about:
  should this be considered as an obvious fix?
  
  i.e. shouldn't all functions declared in headers
have the extern modifier?
  Is this mandatory?
  It doesn't see to change anything in practice, but to me,
it seems like good practice...
... but remember that my C programming knowledge is weak...




Pierre Muller
GDB pascal language maintainer


2012-12-18  Pierre Muller  <muller@sourceware.org>

        * ui-file.h (tee_file_new): Add extern modifier in header
declaration.

Index: ui-file.h
===================================================================
RCS file: /cvs/src/src/gdb/ui-file.h,v
retrieving revision 1.19
diff -u -p -r1.19 ui-file.h
--- ui-file.h   18 Dec 2012 07:01:58 -0000      1.19
+++ ui-file.h   18 Dec 2012 08:31:00 -0000
@@ -135,7 +135,7 @@ extern struct ui_file *gdb_fopen (char *
 /* Create a file which writes to both ONE and TWO.  CLOSE_ONE
    and CLOSE_TWO indicate whether the original files should be
    closed when the new file is closed.  */
-struct ui_file *tee_file_new (struct ui_file *one,
+extern struct ui_file *tee_file_new (struct ui_file *one,
                              int close_one,
                              struct ui_file *two,
                              int close_two);