crash/regression with ia64 targets

Joel Brobecker brobecker@adacore.com
Fri Dec 14 15:14:00 GMT 2012


> I wonder why this crash wasn't visible before.  AFAICS from find_sym_fns,
> the only kinds of objfiles that can be loaded without debugging symbols are
> srec, ihex and tekhex (the latter can have symbols, but we don't read
> in those).
> 
> Ah, indeed, it was.  I can reproduce it:

Nice! (I think)

> Not clear to me which place would be best.  I suggest do nothing,
> as its easiest  :-)

Sold :)

Attached is the patch I am currently testing. It already passed
testing on ia64-linux (ie: I reverted the patch triggering the
crash, ran the testsuite, then un-reverted it, and applied this
patch), no regression. It passesd testing on x64_64-linux as well.

Testing on x86_64-darwin is under way, and I will add ppc-aix and
x86-windows using AdaCore's testsuite.

But given the nature of the changes triggering the cross-platform
testing, I remain fairly confident of the results.

gdb/ChangeLog:

        * symfile.c (syms_from_objfile_1): Renames syms_from_objfile.
        Remove call to init_entry_point_info.  Add OBJFILE's
        section_offsets and num_sections initialization.  Add note
        about entry info in the function documentation.
        (syms_from_objfile): New function.
        * coffread.c (coff_symfile_init): Remove call to
        init_entry_point_info.
        * machoread.c (macho_symfile_init): Likewise.
        * xcoffread.c(xcoff_symfile_init): Likewise.

Thanks,
-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-NULL-objfile-s-section_offsets-dereference-durin.patch
Type: text/x-diff
Size: 4904 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20121214/06a0b2bf/attachment.bin>


More information about the Gdb-patches mailing list