[PATCH v9 1/3] MI: add the -catch-load and -catch-unload commands

Mircea Gherzan mircea.gherzan@intel.com
Tue Dec 11 14:54:00 GMT 2012


On 10.12.2012 21:40, Tom Tromey wrote:
>>>>>> "Mircea" == Mircea Gherzan <mircea.gherzan@intel.com> writes:
>
> Mircea> +++ b/gdb/mi/mi-cmd-break.h
> [...]
> Mircea> +/* Setup the reporting of the insertion of a new breakpoint or
> Mircea> +   catchpoint.  */
> Mircea> +struct cleanup *
> Mircea> +setup_breakpoint_reporting (void);
>
> No break after the "*" here.
>
> Mircea> +  char *actual_cmd = load ? "-catch-load" : "-catch-unload";
>
> Should be const.
>
> This is ok with those fixes.

This and Vladimir's suggestion have been incorporated in v10 of the series.

Can you please merge the series yourself? I don't have "write after 
approval" permission.

Thanks,
Mircea


-- 

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052



More information about the Gdb-patches mailing list