[PATCH 3/7] de-couple %Stop from notification: gdb

[Pedro Alves]

On 12/06/2012 06:16 AM, Yao Qi wrote:

> I agree with you that we can leave the queue global and use 'struct notif' for Stop notification.  Once we have the new notification similar to Stop in the future, we can revisit the generalization here.

Thanks.  Let's do that, please.

> 
>>> >-    {
>>> >-      VEC_free (cached_reg_t, r->regcache);
>>> >-      xfree (r);
>>> >-    }
>>> >+    VEC_free (cached_reg_t, r->regcache);
>>> >  }
>>> >
>>> >-/* Discard all pending stop replies of inferior PID.  If PID is -1,
>>> >-   discard everything.  */
>>> >+static struct notif_reply *
>>> >+remote_notif_alloc_reply_stop (void)
>>> >+{
>>> >+  struct notif_reply *r = (struct notif_reply *) XMALLOC (struct stop_reply);
>> No need for the cast.  See XMALLOC's definition.
>>
> 
> We are casting 'struct stop_reply *' to 'struct notif_reply *', which is needed.

Oh, I must have been blind.  Sorry about that.

> The rest of comments will be addressed in V4.

Thanks.

-- 
Pedro Alves