[patch v4 13/13] btrace, x86: restrict to Atom

[Metzger, Markus T]

> -----Original Message-----
> From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com]
> Sent: Tuesday, November 27, 2012 3:29 PM
> To: Metzger, Markus T
> Cc: gdb-patches@sourceware.org; markus.t.metzger@gmail.com; palves@redhat.com; tromey@redhat.com; kettenis@gnu.org
> Subject: Re: [patch v4 13/13] btrace, x86: restrict to Atom
> 
> On Tue, 27 Nov 2012 15:03:48 +0100, Metzger, Markus T wrote:
> > > There is i386-nat.c for the common functions between these two files.
> >
> > Is it OK put Linux specific code into i386-nat.c?
> 
> True it is not so clear, it would be OK as long as the linux_supports_btrace()
> call is moved out of it, as otherwise it just checks the CPU hardware feature.
> 
> But as you use it also in gdbserver I see now it can be moved to
> common/linux-btrace.[ch] with appropriate #ifdef __i386__ and __x86_64__.
> common/ currently does not have any per-file arch/target configury like gdb/
> and gdbserver/ have, one day it will probably have it but not now.

Pedro seems OK with this, as well. It simplifies the patch a lot. Thanks for pointing this out.

Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052