gdb_test_multiple and empty $message

[Tom Tromey]

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> My impression gdb_test without a message string is used at places
Pedro> we're sending some commands that just prepare the real test.
Pedro> It's a bit arguable whether we should do that, but there you go.
Pedro> But I think that hiding an internal fail in such preparation
Pedro> steps, which are never ever expected to fail (otherwise you'd
Pedro> pass down a message string to begin with) would be actively
Pedro> harmful, and make it harder to grok and debug testsuite results.

Yeah, I agree.

I remember thinking sometimes that it would be nice to have something
like gdb_test_multiple that just returns a status instead of also
logging a pass/fail as a side effect.  I can't remember my scenario now.

Pedro> So I suggest just removing the dead empty string tests from
Pedro> gdb_test_multiple, making the non-empty paths unconditional.

Yes please.

Tom