[RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag)

Tom Tromey tromey@redhat.com
Tue Apr 24 17:42:00 GMT 2012


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> There's no need to commit all this in one go.  Once you split,
Pedro> some of the resulting patches will be dead obvious, and will end up
Pedro> reviewed (if even necessary) and checked in quickly, and thus you end up
Pedro> making progress faster that way.

It seems to me that a variable that is declared but not initialized and
not used is always going to be obviously dead.  I'd be comfortable with
pre-approving all such removals; leaving review for the patches to the
generators and initialized variables.

Tom



More information about the Gdb-patches mailing list