[PATCH/MIPS] Add support Octeon's bbit instructions
Joel Brobecker
brobecker@adacore.com
Fri Apr 20 23:37:00 GMT 2012
Hi Andrew,
This is a superficial review, I was just glancing at the diff
for no real reason when I spotted a couple of little nits. They
may be specific to the GDB project...
> +/* Return nonzero if the gdbarch is an Octeon series. */
> +static int
> +is_octeon (struct gdbarch *gdbarch)
We'd like to have one empty line between the function documentation
and its declaration. Also, 2 spaces after the period :-).
--
Joel
More information about the Gdb-patches
mailing list