[PATCH] sim: bfin: simplify field width processing and fix build warnings

Mike Frysinger vapier@gentoo.org
Sun Apr 1 04:23:00 GMT 2012


This fix the build time warning:
warning: format not a string literal, argument types not checked [-Wformat-nonliteral]

Committed.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

2012-04-01  Mike Frysinger  <vapier@gentoo.org>

	* bfin-dis.c (fmtconst): Replace decimal handling with a single
	sprintf call and the '*' field width.
---
 sim/bfin/bfin-sim.c |   11 +----------
 1 files changed, 1 insertions(+), 10 deletions(-)

diff --git a/sim/bfin/bfin-sim.c b/sim/bfin/bfin-sim.c
index 305b71e..a91687f 100644
--- a/sim/bfin/bfin-sim.c
+++ b/sim/bfin/bfin-sim.c
@@ -232,16 +232,7 @@ fmtconst_str (const_forms_t cf, bs32 x, bu32 pc)
     x <<= constant_formats[cf].scale;
 
   if (constant_formats[cf].decimal)
-    {
-      if (constant_formats[cf].leading)
-	{
-	  char ps[10];
-	  sprintf (ps, "%%%ii", constant_formats[cf].leading);
-	  sprintf (buf, ps, x);
-	}
-      else
-	sprintf (buf, "%i", x);
-    }
+    sprintf (buf, "%*i", constant_formats[cf].leading, x);
   else
     {
       if (constant_formats[cf].issigned && x < 0)
-- 
1.7.8.5



More information about the Gdb-patches mailing list