[committed] : [patch] refactor arm-tdep.c:install_ldr_str_ldrb_strb to handle halfword

Yao Qi yao@codesourcery.com
Sat Sep 17 14:58:00 GMT 2011


On 07/16/2011 02:49 AM, Ulrich Weigand wrote:
> Yao Qi wrote:
> 
>>         * arm-tdep.c (install_ldr_str_ldrb_strb): Renamed to ...
>>         (install_load_store): ... this.  New.
>>         Change parameter BYTE to SIZE.
>>         (arm_copy_ldr_str_ldrb_strb): Update caller.
>>         (arm_decode_ld_st_word_ubyte): Update caller.
> 
> This is OK.  It might be a good idea now to use the new
> install_load_store routine also for arm_copy_extra_ld_st
> (which is where half-/doubleword instructions are decoded
> for ARM) to reduce some duplication.  But that could also
> be done as a follow-on patch ...
> 

Committed.  http://sourceware.org/ml/gdb-cvs/2011-09/msg00111.html

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list