[patch] testsuite: Fix x32, introduce is_amd64_regs_target
Mark Kettenis
mark.kettenis@xs4all.nl
Thu Sep 8 16:01:00 GMT 2011
> Date: Thu, 8 Sep 2011 17:34:54 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> On Sun, 28 Aug 2011 23:05:34 +0200, Mark Kettenis wrote:
> > > From: Jan Kratochvil <jan.kratochvil@redhat.com>
> > > x32 uses triple x86_64-x32-linux* which matches x86_64-*-*.
> >
> > Uh, that's wrong. The middle part if the target triplet is supposed
> > to be the hardware vendor. For i386/amd64 this is pretty much
> > meaningles, but attaching a new meaning to it would be a mistake.
> >
> > Fortunately, your diff doesn't really depend on this. But I think you
> > should adjust the comments in the code.
>
> The triple x86_64-x32-linux* is a reality in binutils, gcc etc.,
Where? Neither the config.guess/config.sub in the gcc svn repo, nor
the one in the src cvs repo will ever return such a triplet.
> And the comments should reflect the reality.
Not my reality.
More information about the Gdb-patches
mailing list