Status of 'blacklist' patch?

[Justin Lebar]

> One more note...

Oops; I should have noticed that.  Fixed.

-Justin

On Fri, Oct 28, 2011 at 3:47 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Justin" == Justin Lebar <justin.lebar@gmail.com> writes:
>
> One more note...
>
> Justin> +int
> Justin> +function_pc_is_marked_for_skip (CORE_ADDR pc)
> Justin> +{
> Justin> +  int searched_for_sal = 0;
> Justin> +  struct symtab_and_line sal;
> Justin> +  char *filename = NULL;
> Justin> +  struct skiplist_entry *e;
> Justin> +
> Justin> +  sal = find_pc_line (pc, 0);
> Justin> +  filename = sal.symtab->filename;
>
> These last two lines should be removed.
> They defeat the lazy computation scheme.
>
> Justin> +             sal = find_pc_line (pc, 0);
> Justin> +             filename = sal.symtab->filename;
>
> I think sal.symtab can be NULL.
>
> Tom
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: skip-7.diff
Type: text/x-patch
Size: 56549 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20111028/71351d2f/attachment.bin>