[PATCH] sim: dv-cfi: include stdbool.h

Joel Brobecker brobecker@adacore.com
Mon Oct 17 16:57:00 GMT 2011


> The dv-cfi code uses the bool type but doesn't include the stdbool.h
> header.  I didn't notice for Blackfin targets as the core Blackfin
> header will include stdbool.h, but most targets don't do this.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> 
> 2011-07-11  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* dv-cfi.c: Include stdbool.h.

I don't think that this is right. stdbool.h is C99, whereas GDB should
build with a C90 compiler.

What we should do is get rid of uses of true and false, and use the
typical zero/nonzero values instead. I think that the blackfin header
and code should be cleaned up accordingly as well.

-- 
Joel



More information about the Gdb-patches mailing list