Make DW_TAG_enumerator's consistent, regardless of containing scope

Sterling Augustine saugustine@google.com
Tue Oct 11 18:27:00 GMT 2011


On Tue, Oct 11, 2011 at 10:06 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Sterling" == Sterling Augustine <saugustine@google.com> writes:
>
> Thanks.
>
> Sterling> 2011-10-07  Sterling Augustine  <saugustine@google.com>
> Sterling>        * dwarf2read.c (partial_die_parent_scope): Rearrange conditional logic.
>
> I think this line needs to wrap.

Done.

> Sterling> +if [get_compiler_info ${binfile} "c++"] {
> Sterling> +    return -1
> Sterling> +}
>
> Does this really do anything?
> (I don't know.)

My dejagnu-fu is very weak, but this test is copied from rtti.exp,
which includes it. The test works just fine without these lines on my
machine, but perhaps that isn't the best indicator, so done.

> This stanza can be replaced by clean_restart.

Done.

Updated patch attached.

Sterling

gdb/ChangeLog
2011-10-07  Sterling Augustine  <saugustine@google.com>

       * dwarf2read.c (partial_die_parent_scope): Rearrange conditional
       logic.

gdb/testsuite/gdb.cp/ChangeLog
2011-10-10  Sterling Augustine  <saugustine@google.com>

       * gdb.cp/Makefile.in: Add namespace-enum test.
       * gdb.cp/namespace-enum.exp: New file.
       * gdb.cp/namespace-enum.c: New file.
       * gdb.cp/namespace-enum-main.c: New file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: enumerator-patch
Type: application/octet-stream
Size: 5019 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20111011/8cfc369c/attachment.obj>


More information about the Gdb-patches mailing list