[RFC - Python] New ObjFile event

Tom Tromey tromey@redhat.com
Wed Oct 5 14:16:00 GMT 2011


>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:

Tom> I think it is best to pass it as part of the event.
Tom> It is ok with me if you also want to have it set the current objfile.

Kevin> I got rid of the "gdb.current_objfile ()" access to the objfile and
Kevin> kept only the "NewObjFile.new_objfile" attribute of the Event object,
Kevin> which indeed makes more sense.
Kevin> I've updated the code and documentation accordingly; could you please
Kevin> tell me if it seems good for you?

It needs another doc review.

One nit on the code:

Kevin> 	(gdbpy_current_objfile): New global variable.
Kevin> 	* python/python.c (gdbpy_current_objfile): Make global.

Now that you aren't setting this in the event generator, there is no
need for these hunks.

The code bits are ok with that changed.

Tom



More information about the Gdb-patches mailing list