[patch 3/5] Print a message on gdb disconnected.

Yao Qi yao@codesourcery.com
Thu Nov 17 03:32:00 GMT 2011


On 11/17/2011 03:04 AM, Pedro Alves wrote:
>> > +  /* Check whether we still have pending tracepoint.  If we have, warn the
>> > +     user that pending tracepoint will no longer work.  */
>> > +  tp_vec = all_tracepoints ();
>> > +  for (ix = 0; VEC_iterate (breakpoint_p, tp_vec, ix, b); ix++)
>> > +    {
>> > +      if (b->loc == NULL || b->loc->shlib_disabled)
> It's not garanteed that the first location is the one that
> is shlib_disabled.  If you want the warning for the shlib_disabled
> cases, you'll need to iterate over the breakpoint's locations.
> 

Yes.  I am still unable to keep it in mind that there may be multiple
locations for one breakpoint :)

>> > +       {
>> > +         has_pending_p = 1;
>> > +         break;
>> > +       }
>> > +    }
>> > +  VEC_free (breakpoint_p, tp_vec);
>> > +
>> > +  if (has_pending_p)
>> > +    warning (_("Pending tracepoint will not be resolved while"
>> > +              " GBD is disconnected\n"));
> Plural, "Pending tracepoints".

Fixed.

-- 
Yao (齐尧)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-pending-tracepoint-on-disconnect.patch
Type: text/x-patch
Size: 1734 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20111117/60d5014f/attachment.bin>


More information about the Gdb-patches mailing list