[PATCH] sim: bfin: allow pushing of SP

Mike Frysinger vapier@gentoo.org
Sat May 14 16:00:00 GMT 2011


The hardware respects this insn, and some code (like the on-chip bootrom)
uses it, so allow it.

Committed.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

2011-05-14  Mike Frysinger  <vapier@gentoo.org>

	* bfin-sim.c (decode_PushPopReg_0): Delete (grp == 1 && reg == 6)
	check for SP reg.
---
 sim/bfin/bfin-sim.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/sim/bfin/bfin-sim.c b/sim/bfin/bfin-sim.c
index 925c058..4e45107 100644
--- a/sim/bfin/bfin-sim.c
+++ b/sim/bfin/bfin-sim.c
@@ -2073,8 +2073,7 @@ decode_PushPopReg_0 (SIM_CPU *cpu, bu16 iw0)
   else
     {
       TRACE_INSN (cpu, "[--SP] = %s;", reg_name);
-      /* Can't push SP.  */
-      if (INSN_LEN == 8 || (grp == 1 && reg == 6))
+      if (INSN_LEN == 8)
 	illegal_instruction_combination (cpu);
 
       sp -= 4;
-- 
1.7.5.rc3



More information about the Gdb-patches mailing list