[RFC] Fixing gdb.base/completion.exp (PR testsuite/12649)
Pedro Alves
pedro@codesourcery.com
Mon May 2 15:50:00 GMT 2011
On Monday 02 May 2011 16:43:45, Joel Brobecker wrote:
> My 2 cents...
>
> > The "\t" method of completion interacts with readline, the
> > "complete command" method doesn't. I think it's useful and
> > important to test the "\t" version, especially since it's
> > what CLI users are using.
>
> I agree. But at the same time, do we need to only test completion
> using this approach only (I initially suggested that we keep 1 test
> that uses this approach, and do the rest with gdb_test "complete ...")?
> Incidentally, the same argument can be made for testing the "complete"
> command as well, as this is what IDEs use.
Note there are "complete foo" tests already in the testfile,
so we already cover both variants, though it's not systematic.
> So, perhaps one possible evolution of the testcase is to write a
> procedure that verifies both forms of completion...
Yes, agreed. I suggested that at least twice in this thread. :-)
--
Pedro Alves
More information about the Gdb-patches
mailing list