[RFA] python/py-breakpoint.c (bppy_set_condition): Stop memory leak.

Michael Snyder msnyder@vmware.com
Fri Mar 11 22:01:00 GMT 2011


Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
> Michael> 2011-03-11  Michael Snyder  <msnyder@vmware.com>
> Michael> 	* python/py-breakpoint.c (bppy_set_condition): Stop memory leak.
> 
> This isn't sufficient to stop the leak.
> 
> Michael>    GDB_PY_SET_HANDLE_EXCEPTION (except);
> 
> This can return.
> 
> We aren't really using cleanups in "pure python" functions like this one.
> You can just explicitly xfree `exp' after the TRY_CATCH.
> However, note the `exp = ""' branch.

Like this?


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: py-breakpoint4.txt
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20110311/86b00792/attachment.txt>


More information about the Gdb-patches mailing list