[RFA] python/py-breakpoint.c (bppy_set_condition): Stop memory leak.

Tom Tromey tromey@redhat.com
Fri Mar 11 21:57:00 GMT 2011


>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> 2011-03-11  Michael Snyder  <msnyder@vmware.com>
Michael> 	* python/py-breakpoint.c (bppy_set_condition): Stop memory leak.

This isn't sufficient to stop the leak.

Michael>    GDB_PY_SET_HANDLE_EXCEPTION (except);

This can return.

We aren't really using cleanups in "pure python" functions like this one.
You can just explicitly xfree `exp' after the TRY_CATCH.
However, note the `exp = ""' branch.

Tom



More information about the Gdb-patches mailing list