[RFA] i386-tdep.c, i386_process_record, document fall-through case.
Mark Kettenis
mark.kettenis@xs4all.nl
Wed Mar 2 22:47:00 GMT 2011
> Date: Wed, 02 Mar 2011 14:34:21 -0800
> From: Michael Snyder <msnyder@vmware.com>
>
> Hui, is this right?
Michael, if it is correct, please document these with a simple
/* FALLTHROUGH */
instead of inventing your own all caps annotations.
Thanks,
Mark
> 2011-03-02 Michael Snyder <msnyder@vmware.com>
>
> * i386-tdep.c (i386_process_record): Document fall through.
>
> Index: i386-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-tdep.c,v
> retrieving revision 1.324
> diff -u -p -u -p -r1.324 i386-tdep.c
> --- i386-tdep.c 8 Feb 2011 14:01:47 -0000 1.324
> +++ i386-tdep.c 2 Mar 2011 22:31:15 -0000
> @@ -4543,6 +4543,7 @@ Do you want to stop the program?"),
> ir.addr -= 1;
> goto no_support;
> }
> + /* ELSE FALL THROUGH */
> case 0x0fb2: /* lss Gv */
> case 0x0fb4: /* lfs Gv */
> case 0x0fb5: /* lgs Gv */
>
> --------------040400010108040302090109--
>
More information about the Gdb-patches
mailing list