Fix magic number in arm-tdep.c

Michael Snyder msnyder@vmware.com
Wed Mar 2 18:32:00 GMT 2011


Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
>>>> -		nextpc = (rn == 15) ? pc_val + 8
>>>> +		nextpc = (rn == ARM_PC_REGNUM) ? pc_val + 8
>>>> : get_frame_register_unsigned (frame, rn);
>>> (? and : should remain in the same column).
>>>
> 
> Michael> I don't agree - : is an operator and should be indented by just
> Michael> two spaces.  As emacs does by default.
> 
> You're supposed to add extra parens to make it line up.
> See the "Formatting" node in the GNU Standards.
> 
> Tom

OK, that would suit me.  ;-)



More information about the Gdb-patches mailing list