[patch 1/2] Fixes to gdb.base/dump.exp: get value from address instead of name
Yao Qi
yao@codesourcery.com
Thu Jun 23 10:28:00 GMT 2011
On 06/22/2011 11:44 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
>
> Yao> +proc capture_value_with_type { expression } {
>
> I don't fully understand this proc. Some comments would help.
>
Sorry about that. Some comments are added in new patch.
> Yao> + if [regexp { \(.*\).*[0-9]+} $expect_out(0,string) output_string] {
>
> Is [0-9]+ really correct?
> I would have thought the results would be in hex.
Oh, you are right. Fixed.
> This would be a good spot for a comment describing the expected output.
>
Comment is added.
> Yao> + pass "$test $output_string"
> Yao> + } else {
> Yao> + fail "$test unable to match regexp"
> Yao> + }
>
> Passes and fails should use the same text.
Fixed.
patch 2/2 is unchanged.
--
Yao (é½å°§)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017-fix-for-test_reload_saved_value.patch
Type: text/x-patch
Size: 4109 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20110623/24579203/attachment.bin>
More information about the Gdb-patches
mailing list