[patch 1/2] Code cleanup: New symbol_filename_ftype
Joel Brobecker
brobecker@adacore.com
Fri Jun 10 21:24:00 GMT 2011
> I will check it in less than a week.
I'd just go ahead and check in now. Patches like these are great, IMO.
Note that it gives us an opportunity to document the meaning of the
various parameters (I am also a fan of naming the parameters in
declarations as well, as Jan did here).
> gdb/
> 2011-06-10 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Code cleanup.
> * dwarf2read.c (dw2_map_symbol_filenames): Use symbol_filename_ftype
> for fun.
> * psymtab.c (map_symbol_filenames_psymtab)
> (map_partial_symbol_filenames): Likewise.
> * psymtab.h: Include symfile.h.
> (map_partial_symbol_filenames): Use symbol_filename_ftype for fun.
> * symfile.h (symbol_filename_ftype): New.
> (struct quick_symbol_functions): Use symbol_filename_ftype for fun of
> map_symbol_filenames, clarify more the naming in comment.
Looks good to me.
--
Joel
More information about the Gdb-patches
mailing list