[0/6] breakpoints_ops for all kinds of breakpoints

Tom Tromey tromey@redhat.com
Fri Jul 22 17:33:00 GMT 2011


>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> I did yet a bit more work on:
Pedro>  <http://sourceware.org/ml/gdb-patches/2011-06/msg00374.html>
Pedro> This converts all breakpoint kinds to the breakpoint_ops
Pedro> mechanism.

Pedro> IMO, this is committable as is.  WDYT?

I read through them all.  I think this is a great series.  Please check
it in.

I'm not particularly fond of patch #4, but I understand why you did it,
and I agree that statically initialized vtables are a pain -- I am often
grepping for all instances and hoping I haven't missed one.  (I wish we
could require designated initializers for these so I could more easily
search for field names...)

I think we could make most of the vtable pointers (but not objects due
to the initialization approach) const.  I think that would help clarity
a bit.  I'm happy to do this after these patches go in.

Tom



More information about the Gdb-patches mailing list